[
https://issues.apache.org/jira/browse/PHOENIX-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024881#comment-17024881
]
Hadoop QA commented on PHOENIX-5591:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12991969/PHOENIX-5591.4.x-HBase-1.5.006.patch
against 4.x-HBase-1.5 branch at commit
b2adb8769ab20267160e48ae7a64f8172392e4d0.
ATTACHMENT ID: 12991969
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + "\"info\".ORG_NAME VARCHAR(255) NULL\n" + ")
COLUMN_ENCODED_BYTES = 0 ";
+ +
"(ID,\"info\".CAR_NUM,\"test\".CAR_NUM,CAP_DATE,ORG_ID,ORG_NAME)
VALUES(?,?,'test-','2016-01-01 00:00:00',11,'orgname1')")) {
+ "CREATE INDEX %s on %s
(\"info\".CAR_NUM,\"test\".CAR_NUM,\"info\".CAP_DATE) ASYNC",
+ IndexTool indexTool = runIndexTool(directApi, useSnapshot,
schemaName, dataTableName, indexTableName, null, 0, failForRegion);
+ assertEquals("1",
PhoenixConfigurationUtil.getNumOfRegions(indexTool.getJob().getConfiguration()));
+ runIndexTool(directApi, useSnapshot, schemaName, dataTableName,
indexTableName, null, -1, failForRegion);
+ private static final Option FAIL_ON_REGION_NUM_CHANGE_OPTION = new
Option("failonrnc", "fail-on-region-num-change", false,
+ "If specified, fails if the number of regions changes since index
tool started (optional)");
+ "Data table split/merge happened during Index rebuild. Old region
cnt=%d, New region cnt = %d. "
+ String strNumOfRegions =
PhoenixConfigurationUtil.getNumOfRegions(context.getConfiguration());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexBuildTimestampIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3351//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3351//console
This message is automatically generated.
> IndexTool should detect the number of region splits in the beginning and end
> and fail if there is a difference
> --------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5591
> URL: https://issues.apache.org/jira/browse/PHOENIX-5591
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5591.4.x-HBase-1.4.001.patch,
> PHOENIX-5591.4.x-HBase-1.4.002.patch, PHOENIX-5591.4.x-HBase-1.4.003.patch,
> PHOENIX-5591.4.x-HBase-1.5.006.patch, PHOENIX-5591.master.002.patch,
> PHOENIX-5591.master.006.patch, PHOENIX-5591.master.007.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
