[
https://issues.apache.org/jira/browse/PHOENIX-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025225#comment-17025225
]
Hadoop QA commented on PHOENIX-5268:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12992029/PHOENIX-5268.master.v3.patch
against master branch at commit 41a24eb35244799bdd2f49ba157f29b40b3564e4.
ATTACHMENT ID: 12992029
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 374 javac compiler
warnings (more than the master's current 361 warnings).
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if
(CompatPermissionUtil.getPermissionFromUP(permToTable).implies(action)) {
+
accessExists.addAll(Arrays.asList(CompatPermissionUtil.getPermissionFromUP(permToTable).getActions()));
+
if(AuthUtil.isGroupPrincipal(CompatPermissionUtil.getUserFromUP(userPermission))){
+ AUDITLOG.warn("Users of GROUP:" +
CompatPermissionUtil.getUserFromUP(userPermission)
+ handleRequireAccessOnDependentTable(request,
CompatPermissionUtil.getUserFromUP(userPermission),
+ && CompatPermissionUtil.authorizeUserTable(accessChecker,
user, table, action)) {
+ List<UserPermission> permissionsForUser =
getPermissionForUser(perms, user.getShortName());
+ if
(CompatPermissionUtil.getPermissionFromUP(permissionForUser).implies(action)) {
return true; }
+ if
(CompatPermissionUtil.getPermissionFromUP(permissionForUser).implies(action)) {
return true; }
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3354//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3354//console
This message is automatically generated.
> HBase 2.1/2.2 compatibility
> ---------------------------
>
> Key: PHOENIX-5268
> URL: https://issues.apache.org/jira/browse/PHOENIX-5268
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Istvan Toth
> Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5268.master.v1.patch,
> PHOENIX-5268.master.v2.patch, PHOENIX-5268.master.v3.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> HBASE-21754 introduces a new abstract method to RpcScheduler:
> {{getMetaPriorityQueueLength()}}
> This means that Phoenix does not build against HBase 2.0.5.
> FYI [[email protected]], [~Jaanai].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
