[
https://issues.apache.org/jira/browse/PHOENIX-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028497#comment-17028497
]
Viraj Jasani commented on PHOENIX-5697:
---------------------------------------
Thanks for the review [~gjacoby]
Sorry for the delay in providing 4.x patches. The attached patch
(PHOENIX-5697.4.x-HBase-1.5.000.patch) can be applied directly to
4.x-HBase-1.5/1.4/1.3, 4.15-HBase-1.5/1.4/1.3, 4.14-HBase-1.4/1.3 branches.
> Avoid resource leakage with try-with-resources
> ----------------------------------------------
>
> Key: PHOENIX-5697
> URL: https://issues.apache.org/jira/browse/PHOENIX-5697
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0, 4.15.1
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: phoenix-hardening
> Attachments: PHOENIX-5697.4.x-HBase-1.5.000.patch,
> PHOENIX-5697.master.000.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There are places where we catch IOException in finally block while closing a
> closable resource or have to do redundant null check. If we could use
> try-with-resources to deal with closure of resources, that would not let us
> worry about catching IOException or NPE while closing the resources and would
> be a better replacement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
