[
https://issues.apache.org/jira/browse/PHOENIX-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028552#comment-17028552
]
Hadoop QA commented on PHOENIX-5697:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12992445/PHOENIX-5697.4.x-HBase-1.5.000.patch
against 4.x-HBase-1.5 branch at commit
b27168de1922d429229935b16eef49c00a88aab1.
ATTACHMENT ID: 12992445
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3378//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3378//console
This message is automatically generated.
> Avoid resource leakage with try-with-resources
> ----------------------------------------------
>
> Key: PHOENIX-5697
> URL: https://issues.apache.org/jira/browse/PHOENIX-5697
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0, 4.15.1
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: phoenix-hardening
> Attachments: PHOENIX-5697.4.x-HBase-1.5.000.patch,
> PHOENIX-5697.master.000.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There are places where we catch IOException in finally block while closing a
> closable resource or have to do redundant null check. If we could use
> try-with-resources to deal with closure of resources, that would not let us
> worry about catching IOException or NPE while closing the resources and would
> be a better replacement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
