gokceni commented on a change in pull request #701: PHOENIX-5709 Simplify index
update generation code for consistent glo…
URL: https://github.com/apache/phoenix/pull/701#discussion_r376113211
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##########
@@ -1592,7 +1592,7 @@ private int estimateIndexRowKeyByteSize(int
indexColByteSize) {
*/
private void initCachedState() {
byte[] emptyKvQualifier =
EncodedColumnsUtil.getEmptyKeyValueInfo(encodingScheme).getFirst();
- dataEmptyKeyValueRef = new
ColumnReference(emptyKeyValueCFPtr.copyBytesIfNecessary(), emptyKvQualifier);
+ dataEmptyKeyValueRef = new ColumnReference(dataEmptyKeyValueCF,
emptyKvQualifier);
Review comment:
Is there a chance that dataEmptyKeyValueCF is not initialized?
I see that it is initialized in one private constructor but not in the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
