swaroopak commented on a change in pull request #701: PHOENIX-5709 Simplify 
index update generation code for consistent glo…
URL: https://github.com/apache/phoenix/pull/701#discussion_r376139701
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
 ##########
 @@ -565,12 +829,6 @@ private void prepareIndexMutations(
                   // add the VERIFIED cell, which is the empty cell
 
 Review comment:
   Since the verified cell is getting added in 
`prepareIndexMutationsForIndexRebuild`, do you mind moving this comment inside 
else block or changing it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to