[
https://issues.apache.org/jira/browse/PHOENIX-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036193#comment-17036193
]
Istvan Toth commented on PHOENIX-5537:
--------------------------------------
Nit:
Instead of a comment, you should use the
com.google.common.annotations.VisibleForTestsing annotation to mark the new
getter method.
> Phoenix-4701 made hard coupling between phoenix.log.level and getting request
> metrics.
> --------------------------------------------------------------------------------------
>
> Key: PHOENIX-5537
> URL: https://issues.apache.org/jira/browse/PHOENIX-5537
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Daniel Wong
> Assignee: Richard Antal
> Priority: Minor
> Fix For: 5.1.0, 4.15.1, 4.16.0
>
> Attachments: PHOENIX-5537.master.v1.patch,
> PHOENIX-5537.master.v2.patch
>
>
> Phoenix-4701 made hard coupling between phoenix.log.level and getting request
> metrics. For users who do not want to enable system to log this causes a
> regression from earlier behavior where metrics were populated. FYI [~ankit]
> {code:java}
> public OverAllQueryMetrics(boolean isRequestMetricsEnabled, LogLevel
> connectionLogLevel) { public OverAllQueryMetrics(boolean
> isRequestMetricsEnabled, LogLevel connectionLogLevel) { queryWatch = new
> MetricsStopWatch(WALL_CLOCK_TIME_MS.isLoggingEnabled(connectionLogLevel));
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
