[
https://issues.apache.org/jira/browse/PHOENIX-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036323#comment-17036323
]
Hadoop QA commented on PHOENIX-5537:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12993370/PHOENIX-5537.master.v3.patch
against master branch at commit cf67e5d4a46183ba11c8c0547034f075b57b1ab0.
ATTACHMENT ID: 12993370
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3439//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3439//console
This message is automatically generated.
> Phoenix-4701 made hard coupling between phoenix.log.level and getting request
> metrics.
> --------------------------------------------------------------------------------------
>
> Key: PHOENIX-5537
> URL: https://issues.apache.org/jira/browse/PHOENIX-5537
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Daniel Wong
> Assignee: Richard Antal
> Priority: Minor
> Fix For: 5.1.0, 4.15.1, 4.16.0
>
> Attachments: PHOENIX-5537.master.v1.patch,
> PHOENIX-5537.master.v2.patch, PHOENIX-5537.master.v3.patch
>
>
> Phoenix-4701 made hard coupling between phoenix.log.level and getting request
> metrics. For users who do not want to enable system to log this causes a
> regression from earlier behavior where metrics were populated. FYI [~ankit]
> {code:java}
> public OverAllQueryMetrics(boolean isRequestMetricsEnabled, LogLevel
> connectionLogLevel) { public OverAllQueryMetrics(boolean
> isRequestMetricsEnabled, LogLevel connectionLogLevel) { queryWatch = new
> MetricsStopWatch(WALL_CLOCK_TIME_MS.isLoggingEnabled(connectionLogLevel));
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
