gjacoby126 commented on a change in pull request #701: PHOENIX-5709 Simplify
index update generation code for consistent glo…
URL: https://github.com/apache/phoenix/pull/701#discussion_r382861609
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -750,16 +749,38 @@ public int compare(Mutation o1, Mutation o2) {
if (ts1 < ts2) {
return 1;
}
- if (o1 instanceof Put && o2 instanceof Delete) {
+ if (o1 instanceof Delete && o2 instanceof Put) {
return -1;
}
- if (o1 instanceof Delete && o2 instanceof Put) {
+ if (o1 instanceof Put && o2 instanceof Delete) {
return 1;
}
return 0;
}
};
+ private boolean isDeleteFamily(Mutation mutation) {
+ for (List<Cell> cells : mutation.getFamilyCellMap().values()) {
+ for (Cell cell : cells) {
+ if (cell.getType() == DeleteFamily) {
+ return true;
+ }
+ }
+ }
+ return false;
+ }
+
+ /**
+ * indexRow is the set of all cells of all the row version of an index row
from the index table. These are actual
+ * actual cells. We group these cells based on timestamp and type (put vs
delete), and form the actual set of
Review comment:
nit: "actual actual"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
