swaroopak commented on a change in pull request #701: PHOENIX-5709 Simplify 
index update generation code for consistent glo…
URL: https://github.com/apache/phoenix/pull/701#discussion_r383080700
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
 ##########
 @@ -1110,9 +1111,20 @@ private static PTable deserializeTable(byte[] b) {
 
     private RegionScanner rebuildIndices(final RegionScanner innerScanner, 
final Region region, final Scan scan,
                                          final RegionCoprocessorEnvironment 
env) throws IOException {
-
-        RegionScanner scanner = new IndexRebuildRegionScanner(innerScanner, 
region, scan, env, this);
-        return scanner;
+        if (!scan.isRaw()) {
 
 Review comment:
   nit: assuming this is for rebuilding the history from data, a comment 
stating so would be useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to