gokceni commented on a change in pull request #701: PHOENIX-5709 Simplify index
update generation code for consistent glo…
URL: https://github.com/apache/phoenix/pull/701#discussion_r387833379
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -1272,6 +1272,9 @@ private static Put
prepareIndexPutForRebuid(IndexMaintainer indexMaintainer, Imm
byte[] indexRowKey = indexMaintainer.buildRowKey(mergedRowVG,
rowKeyPtr,
null, null, HConstants.LATEST_TIMESTAMP);
indexPut = new Put(indexRowKey);
+ } else {
+ removeEmptyColumn(indexPut,
indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(),
Review comment:
Can we add a comment here why we remove the empty column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
