[
https://issues.apache.org/jira/browse/PHOENIX-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056623#comment-17056623
]
Hadoop QA commented on PHOENIX-5607:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12996360/PHOENIX-5607.4.x.v1.patch
against 4.x branch at commit c69f78f124ef0d248a4106c374cbf631ab0b3be0.
ATTACHMENT ID: 12996360
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conf.set(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB,
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
+ if (sqlCommand.length() == 0 || sqlCommand.startsWith("/") ||
sqlCommand.startsWith("*")) continue;
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3568//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3568//console
This message is automatically generated.
> Client-server backward compatibility tests
> -------------------------------------------
>
> Key: PHOENIX-5607
> URL: https://issues.apache.org/jira/browse/PHOENIX-5607
> Project: Phoenix
> Issue Type: Test
> Affects Versions: 4.15.0
> Reporter: Lars Hofhansl
> Assignee: Sandeep Guggilam
> Priority: Blocker
> Labels: phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5607.4.x-HBase-1.3.v1.patch,
> PHOENIX-5607.4.x-HBase-1.3.v2.patch, PHOENIX-5607.4.x-HBase-1.3.v3.patch,
> PHOENIX-5607.4.x-HBase-1.3.v4.patch, PHOENIX-5607.4.x-HBase-1.3.v5.patch,
> PHOENIX-5607.4.x-HBase-1.4.v1.patch, PHOENIX-5607.4.x-HBase-1.5.v1.patch,
> PHOENIX-5607.4.x.v1.patch, PHOENIX-5607.master.v1.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Filing this as a blocker for 4.16.0.
> As we've seen with the various failed attempts to release 4.15.0 Phoenix'
> backwards compatibility story is weak, and lacks tests - in fact there're no
> tests.
> We should not allow to ship 4.16.0 without improving that and without tests.
> [~ckulkarni], [~gjacoby] , FYI, what we discussed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
