[
https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060228#comment-17060228
]
Istvan Toth edited comment on PHOENIX-5778 at 3/16/20, 1:47 PM:
----------------------------------------------------------------
Keep in mind that this a TEST dependency.
It will not burden the finished artifacts in any way. They won't get any
bigger, nor will they have more polluted classpath. It is only ever loaded and
referenced during the build process.
If it was only the for the case where create the key pair for Avatica, I'd
agree that we should just use a different class to create the keypair. But we
also use it to initialize the HDFS cluster, and where we need to set the hadoop
properties. If there was a hadoop class with similar functionality, we'd use
that, but there isn't, so the HBase class is the next best thing.
was (Author: stoty):
Keep in mind that this a TEST dependency.
It will not burden the finished artifacts in any way. They won't get any
bigger, nor will they have more polluted classpath. It is only ever loaded and
referenced during the build process.
> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
> Key: PHOENIX-5778
> URL: https://issues.apache.org/jira/browse/PHOENIX-5778
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Priority: Major
> Fix For: 5.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase
> class/interface which not marked IA.Public. KeyStoreTestUtil is just a
> static util class. I thought phoenix query server can copy a new one and not
> depend on hbase's KeyStoreTestUtil.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
