[
https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060239#comment-17060239
]
Guanghao Zhang edited comment on PHOENIX-5778 at 3/16/20, 2:18 PM:
-------------------------------------------------------------------
bq. It is only ever loaded and referenced during the build process.
If new version hbase (2.3.x+) move this KeyStoreTestUtil to other module, we
need open new issue to fix the build problem and add new profile to pom, this
will make the pom.xml bigger?
And if new version hbase (2.3.x+) change KeyStoreTestUtil's class name or
package, we have to add different code to handle the compatibility?
was (Author: zghaobac):
bq. It is only ever loaded and referenced during the build process.
If new version hbase (2.3.x+) move this KeyStoreTestUtil to other module, we
need open new issue to fix the build problem and add new profile to pom, this
will make the pom.xml bigger?
> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
> Key: PHOENIX-5778
> URL: https://issues.apache.org/jira/browse/PHOENIX-5778
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: queryserver-1.0.0
> Reporter: Guanghao Zhang
> Priority: Major
> Fix For: queryserver-1.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase
> class/interface which not marked IA.Public. KeyStoreTestUtil is just a
> static util class. I thought phoenix query server can copy a new one and not
> depend on hbase's KeyStoreTestUtil.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
