[ 
https://issues.apache.org/jira/browse/PHOENIX-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063055#comment-17063055
 ] 

Kadir OZDEMIR commented on PHOENIX-5751:
----------------------------------------

[~abhishek.chouhan], I have two question on this. The first one is related to 
the patch. Are sure that TableInfo.isDataTable() is reliable to check if a 
table is a really data table? I remember this method returns true even for the 
base index tables (for view indexes).  

The second question is for 4.14 branches. Do we still maintain them? I skipped 
updating them for my last jira. I was under the impression that after unifying 
4.x branches, we do not need to maintain them.

> Remove redundant IndexUtil#isGlobalIndexCheckEnabled() calls for immutable 
> data tables
> --------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5751
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5751
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.0, 4.14.3
>            Reporter: Swaroopa Kadam
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>             Fix For: 5.1.0, 4.15.1, 4.14.4
>
>         Attachments: PHOENIX-5751-4.14-HBase-1.3.patch, 
> PHOENIX-5751-4.14-HBase-1.3.patch, PHOENIX-5751-master.patch
>
>
> We don't need to add and check if globalIndexChecker is enabled on data table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to