[
https://issues.apache.org/jira/browse/PHOENIX-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063183#comment-17063183
]
Abhishek Singh Chouhan commented on PHOENIX-5751:
-------------------------------------------------
[~kozdemir] As you mentioned, it turned out isDataTable was not a reliable way
after all. We in fact set isDataTable true for many cases. Putting up an
updated patch which passes the failed tests locally. Please have a look.
I did not see an official discussion on EOMing 4.14, i'm under the impression
we should maintain it till the time a branch is officially active, which is
also why i thought all the fixes should also go in 4.15(which also seems to be
in an unofficial dead state). We should perhaps take it to a discuss thread if
we want to EOM 4.14,4.15.
> Remove redundant IndexUtil#isGlobalIndexCheckEnabled() calls for immutable
> data tables
> --------------------------------------------------------------------------------------
>
> Key: PHOENIX-5751
> URL: https://issues.apache.org/jira/browse/PHOENIX-5751
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 4.14.3
> Reporter: Swaroopa Kadam
> Assignee: Abhishek Singh Chouhan
> Priority: Major
> Fix For: 5.1.0, 4.15.1, 4.14.4
>
> Attachments: PHOENIX-5751-4.14-HBase-1.3.patch,
> PHOENIX-5751-4.14-HBase-1.3.patch, PHOENIX-5751-master.patch
>
>
> We don't need to add and check if globalIndexChecker is enabled on data table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
