dbwong commented on a change in pull request #736: PHOENIX-5698 Phoenix Query
with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/736#discussion_r397430016
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/expression/InListExpressionTest.java
##########
@@ -62,4 +70,68 @@ public void testHashCode() throws Exception {
+ hashCode, firstHashCode, hashCode);
}
}
+
+ @Test
+ public void testGetSortedRowValueConstructorExpressionListNotPkOrder() {
+ testGetSortedRowValueConstructorExpressionList(false);
+ }
+
+ @Test
+ public void testGetSortedRowValueConstructorExpressionListPkOrder() {
+ testGetSortedRowValueConstructorExpressionList(true);
+ }
+
+ private void testGetSortedRowValueConstructorExpressionList(boolean
isPkOrder) {
Review comment:
@yanxinyi don't like that particular refactoring? I think it will make the
code a lot cleaner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
