yanxinyi commented on a change in pull request #736: PHOENIX-5698 Phoenix Query
with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/736#discussion_r397434968
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/expression/InListExpressionTest.java
##########
@@ -62,4 +70,68 @@ public void testHashCode() throws Exception {
+ hashCode, firstHashCode, hashCode);
}
}
+
+ @Test
+ public void testGetSortedRowValueConstructorExpressionListNotPkOrder() {
+ testGetSortedRowValueConstructorExpressionList(false);
+ }
+
+ @Test
+ public void testGetSortedRowValueConstructorExpressionListPkOrder() {
+ testGetSortedRowValueConstructorExpressionList(true);
+ }
+
+ private void testGetSortedRowValueConstructorExpressionList(boolean
isPkOrder) {
Review comment:
It used to pass a list of expression that does sorting and reconstructing
rvc.
the new implementation takes a list of `InListColumnKeyValuePair` instead so
that I can test sorting logic and construction logic in a method and test
reconstructed a new rvc in this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
