dbwong commented on a change in pull request #745: PHOENIX-5801: Connection
leak when creating a view with a where condition
URL: https://github.com/apache/phoenix/pull/745#discussion_r399498700
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
##########
@@ -648,6 +648,21 @@ public void
testMutationMetricsWhenUpsertingToMultipleTables() throws Exception
}
}
+ @Test
+ public void createViewWithWhereConditionNoConnLeak() throws SQLException {
Review comment:
But on the note of UTs is it possible to add a UT to
WhereConstantParser.java? We may need a static factory and additional
refactoring to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
