ChinmaySKulkarni commented on a change in pull request #745: PHOENIX-5801:
Connection leak when creating a view with a where condition
URL: https://github.com/apache/phoenix/pull/745#discussion_r399515907
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
##########
@@ -648,6 +648,21 @@ public void
testMutationMetricsWhenUpsertingToMultipleTables() throws Exception
}
}
+ @Test
+ public void createViewWithWhereConditionNoConnLeak() throws SQLException {
Review comment:
I think that'll need a larger refactoring Jira. I also think
WhereConstantParser should be in the util package rather than coprocessor. Once
refactored, it will be possible to add unit tests for that class. Does that
sound good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
