[
https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085104#comment-17085104
]
Mingliang Liu commented on PHOENIX-5789:
----------------------------------------
Yes in {{*IT.java}}, we can use the simpler way without static change. Ideally
one application (JVM) can have a singleton static object mapper (e.g. using a
{{Util.getMapper()}} helper method). If that is much code change we choose to
do later, I think we can still make mapper static in {{PhoenixMRJobSubmitter}}
and {{IndexRebuildTask}} as well. I'm +0 if you leave it as is.
{quote}((ObjectNode) jsonNode).put(TASK_DETAILS, taskStatus);
{quote}
Is {{ObjectNode.set()}} a bit better? I remember some discussions but only find
an old link now [https://github.com/FasterXML/jackson-databind/issues/21]
Either is fine if we use sparingly.
> try to standardize on a JSON library
> ------------------------------------
>
> Key: PHOENIX-5789
> URL: https://issues.apache.org/jira/browse/PHOENIX-5789
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Richard Antal
> Priority: Minor
> Attachments: PHOENIX-5789.4.x.v1.patch, PHOENIX-5789.4.x.v3.patch,
> PHOENIX-5789.4.x.v4.patch, PHOENIX-5789.master.v1.patch,
> PHOENIX-5789.master.v2.patch, PHOENIX-5789.master.v3.patch,
> PHOENIX-5789.master.v4.patch
>
>
> Phoenix uses at least the following JSON libraries:
> * gson
> * jackson
> * jettison
> Of these, only the jackson usage is performance critical, as it is used
> during bulk loading.
> Try to standardize on a single one to reduce dependency hell.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
