[
https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091509#comment-17091509
]
Hadoop QA commented on PHOENIX-5789:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13001054/PHOENIX-5789.4.x.v7.patch
against 4.x branch at commit 0b3c8a378a2ebb7cbbb6bcc3e6b308c37da1e358.
ATTACHMENT ID: 13001054
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 0 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "_comment": "Lists all phoenix compatible client versions against the
current branch version for a given hbase profile If hbase profile is 1.3,
phoenix client versions 4.14.3 and 4.15.0 are tested against current branch
version",
+ String json =
JacksonUtil.getObjectWriter().writeValueAsString(props);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3786//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3786//console
This message is automatically generated.
> try to standardize on a JSON library
> ------------------------------------
>
> Key: PHOENIX-5789
> URL: https://issues.apache.org/jira/browse/PHOENIX-5789
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Richard Antal
> Priority: Minor
> Attachments: PHOENIX-5789.4.x.v1.patch, PHOENIX-5789.4.x.v3.patch,
> PHOENIX-5789.4.x.v4.patch, PHOENIX-5789.4.x.v5.patch,
> PHOENIX-5789.4.x.v6.patch, PHOENIX-5789.4.x.v7.patch,
> PHOENIX-5789.master.addendum.patch, PHOENIX-5789.master.addendum.v2.patch,
> PHOENIX-5789.master.addendum.v3.patch, PHOENIX-5789.master.v1.patch,
> PHOENIX-5789.master.v2.patch, PHOENIX-5789.master.v3.patch,
> PHOENIX-5789.master.v4.patch
>
>
> Phoenix uses at least the following JSON libraries:
> * gson
> * jackson
> * jettison
> Of these, only the jackson usage is performance critical, as it is used
> during bulk loading.
> Try to standardize on a single one to reduce dependency hell.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
