[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093354#comment-17093354
]
Hadoop QA commented on PHOENIX-5872:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13001296/PHOENIX-5872.4.x.patch
against 4.x branch at commit 07bd1c5a1df0b7cded9fd2ff0177afd792a714b2.
ATTACHMENT ID: 13001296
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String ddl = "create table " + tableName + " (i integer not null
primary key, j integer) SALT_BUCKETS=256 ";
+ assertTrue(String.format("Found %d connections still
open.",connections),2 >= connections);
+ assertTrue(String.format("Found %d internal connections still
open.",connections),2 >= connections);
+ OPEN_INTERNAL_PHOENIX_CONNECTIONS_COUNTER("io", "Number of open internal
phoenix connections",LogLevel.OFF, PLong.INSTANCE),
+ this.maxInternalConnectionsAllowed =
config.getInt(QueryServices.INTERNAL_CONNECTION_MAX_ALLOWED_CONNECTIONS,
+ int futureConnections = 1 + (
connection.isInternalConnection() ? internalConnectionCount : connectionCount);
+ int allowedConnections = connection.isInternalConnection()
? maxInternalConnectionsAllowed : maxConnectionsAllowed;
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.NEW_CONNECTION_THROTTLED).
+ if (returnSequenceValues || shouldThrottleNumConnections){ //still
need to decrement connection count
+ // Note: The optimal scan boundary for the above query is ['CCC' -
*), however, I don't see an easy way to fix this currently so prioritizing.
Opened JIRA
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.compile.WhereOptimizerTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3791//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3791//console
This message is automatically generated.
> Close Internal Phoenix Connections that were running during cancel
> ------------------------------------------------------------------
>
> Key: PHOENIX-5872
> URL: https://issues.apache.org/jira/browse/PHOENIX-5872
> Project: Phoenix
> Issue Type: Bug
> Reporter: Daniel Wong
> Assignee: Daniel Wong
> Priority: Major
> Attachments: PHOENIX-5872.4.x.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> 3 part approach:
> 1 don't count internal phoenix connections toward the client limit.
> 2 count internal phoenix connections toward a newly defined limit
> 3 track parent and child relationships between connections to close those
> connections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
