[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099433#comment-17099433
]
Hadoop QA commented on PHOENIX-5872:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13002031/PHOENIX-5872.master.patch
against master branch at commit 490c18d7fe59b2199d4d3aacf350c8c2e393c258.
ATTACHMENT ID: 13002031
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * Note that some tests for concurrentConnections live in
PhoenixMetricsIT.java which also test the metric emission
+
hbaseTestUtil.startMiniCluster(StartMiniClusterOption.builder().rsClass(DelayedRegionServer.class).build());
+ String ddl = "create table " + tableName + " (i integer not null
primary key, j integer) SALT_BUCKETS=256 ";
+ try(Connection conn = DriverManager.getConnection(connectionUrl,
props); Statement statement = conn.createStatement()) {
+ assertEquals(String.format("Found %d connections still open.",
connections),0,connections);
+ assertEquals(String.format("Found %d internal connections still
open.", connections),0 ,connections);
+ private Object queueCreationLock = new Object(); // lock for the lazy init
path of childConnections structure
+ OPEN_INTERNAL_PHOENIX_CONNECTIONS_COUNTER("io", "Number of open internal
phoenix connections",LogLevel.OFF, PLong.INSTANCE),
+ this.maxInternalConnectionsAllowed =
config.getInt(QueryServices.INTERNAL_CONNECTION_MAX_ALLOWED_CONNECTIONS,
+ this.shouldThrottleNumConnections = (maxConnectionsAllowed > 0) ||
(maxInternalConnectionsAllowed > 0);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3810//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3810//console
This message is automatically generated.
> Close Internal Phoenix Connections that were running during cancel
> ------------------------------------------------------------------
>
> Key: PHOENIX-5872
> URL: https://issues.apache.org/jira/browse/PHOENIX-5872
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.3, 4.x
> Reporter: Daniel Wong
> Assignee: Daniel Wong
> Priority: Major
> Attachments: PHOENIX-5872.4.x.patch, PHOENIX-5872.master.patch,
> PHOENIX-5872v2.4.x.patch, PHOENIX-5872v3.4.x.patch, PHOENIX-5872v4.4.x.patch,
> PHOENIX-5872v5.4.x.patch
>
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> 3 part approach:
> 1 don't count internal phoenix connections toward the client limit.
> 2 count internal phoenix connections toward a newly defined limit
> 3 track parent and child relationships between connections to close those
> connections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
