[
https://issues.apache.org/jira/browse/PHOENIX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101133#comment-17101133
]
Chinmay Kulkarni commented on PHOENIX-5842:
-------------------------------------------
Thanks [~sandeep.guggilam]. Changes look good. Where did we define "deactivate"
variable's value?
Also, can you please check the latest QA run? Mostly unrelated to your changes,
but still please take a look once
> Code Coverage tool for Phoenix
> ------------------------------
>
> Key: PHOENIX-5842
> URL: https://issues.apache.org/jira/browse/PHOENIX-5842
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Sandeep Guggilam
> Assignee: Sandeep Guggilam
> Priority: Major
> Labels: quality-improvement
> Attachments: PHOENIX-5842.4.x.v1.patch, PHOENIX-5842.4.x.v2.patch
>
>
> Currently we don't have any code coverage tool for Phoenix. This is required
> for us to measure the test coverage and helps us in improving the test suite
> further till we reach may be 80% coverage
> The test coverage results can also be integrated into the Hadoop QA run of
> the precommit build such that the reviewers could take a look at the report
> and see if the added code doesn't have enough coverage
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
