[ https://issues.apache.org/jira/browse/PHOENIX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105118#comment-17105118 ]
Hadoop QA commented on PHOENIX-5842: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/13002658/PHOENIX-5842_addendum.patch against master branch at commit 8fd11783cd132817604f9e84a4e4b8d716042e0e. ATTACHMENT ID: 13002658 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation, build, or dev patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PermissionNSEnabledIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3842//testReport/ Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3842//artifact/phoenix-core/target/site/jacoco/index.html Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3842//console This message is automatically generated. > Code Coverage tool for Phoenix > ------------------------------ > > Key: PHOENIX-5842 > URL: https://issues.apache.org/jira/browse/PHOENIX-5842 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.0.0, 4.15.0, 4.14.3 > Reporter: Sandeep Guggilam > Assignee: Sandeep Guggilam > Priority: Major > Labels: quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5842.4.x.v1.patch, PHOENIX-5842.4.x.v2.patch, > PHOENIX-5842.master.v1.patch, PHOENIX-5842_addendum.patch > > > Currently we don't have any code coverage tool for Phoenix. This is required > for us to measure the test coverage and helps us in improving the test suite > further till we reach may be 80% coverage > The test coverage results can also be integrated into the Hadoop QA run of > the precommit build such that the reviewers could take a look at the report > and see if the added code doesn't have enough coverage -- This message was sent by Atlassian Jira (v8.3.4#803005)