stoty commented on a change in pull request #28:
URL: https://github.com/apache/phoenix-queryserver/pull/28#discussion_r425615887
##########
File path:
load-balancer/src/it/java/org/apache/phoenix/end2end/LoadBalancerEnd2EndIT.java
##########
@@ -139,6 +142,37 @@ public void testSingletonPropertyForLoadBalancer(){
Assert.assertTrue(" the load balancer is not singleton",loadBalancer
== anotherloadBalancerRef );
}
+ @Test
+ public void testZkConnectString() {
+ // server port is different from the port which is set by user
Review comment:
Nit Technically, this is a UT, but we tend not worry about the
distinction much.
##########
File path:
load-balancer/src/main/java/org/apache/phoenix/loadbalancer/service/LoadBalanceZookeeperConfImpl.java
##########
@@ -65,8 +65,23 @@ public String getServiceName(){
@Override
public String getZkConnectString(){
- return
String.format("%s:%s",configuration.get(QueryServerProperties.ZOOKEEPER_QUORUM_ATTRIB,
-
"localhost"),configuration.get(QueryServerProperties.ZOOKEEPER_PORT_ATTRIB,"2181"));
+ String[] serverHosts =
configuration.getStrings(QueryServerProperties.ZOOKEEPER_QUORUM_ATTRIB,
"localhost");
+ String clientPort =
configuration.get(QueryServerProperties.ZOOKEEPER_PORT_ATTRIB, "2181");
+ StringBuilder zkConnectionString = new StringBuilder();
Review comment:
Why not just call ZKConfig.standardizeZKQuorumServerString() from HBase?
We are pulling in hbase-common anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
