stoty commented on a change in pull request #28:
URL: https://github.com/apache/phoenix-queryserver/pull/28#discussion_r425615887
##########
File path:
load-balancer/src/it/java/org/apache/phoenix/end2end/LoadBalancerEnd2EndIT.java
##########
@@ -139,6 +142,37 @@ public void testSingletonPropertyForLoadBalancer(){
Assert.assertTrue(" the load balancer is not singleton",loadBalancer
== anotherloadBalancerRef );
}
+ @Test
+ public void testZkConnectString() {
+ // server port is different from the port which is set by user
Review comment:
Nit Technically, this is a UT, but we tend not worry about the
distinction much.
(The test is fine as is, but some may argue that it should be in src/test,
not src/it )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
