[ 
https://issues.apache.org/jira/browse/PHOENIX-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110227#comment-17110227
 ] 

Hadoop QA commented on PHOENIX-5902:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13003256/PHOENIX-5902.4.x.v1.patch
  against 4.x branch at commit 49599fd89b6cfa9cab9d7d3f6dcf4bdc5428915a.
  ATTACHMENT ID: 13003256

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.ChunkedResultIteratorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.util.IndexScrutinyIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinNoIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3861//testReport/
Code Coverage results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3861//artifact/phoenix-core/target/site/jacoco/index.html
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3861//console

This message is automatically generated.

> Document or fix new compat jar behavior.
> ----------------------------------------
>
>                 Key: PHOENIX-5902
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5902
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.16.0
>            Reporter: Lars Hofhansl
>            Assignee: Istvan Toth
>            Priority: Blocker
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5902.4.x.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After PHOENIX-5808 (I think), the compat classes are no longer included in 
> Phoenix' server jar.
> This causes the HBase regionservers to fail with:
> 2020-05-15 15:35:36,098 FATAL [RS_OPEN_PRIORITY_REGION-host:16201-1] 
> regionserver.HRegionServer: ABORTING region server think,16201,1589581955446: 
> The coprocessor 
> org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver threw 
> java.lang.NoClassDefFoundError: 
> org/apache/phoenix/compat/hbase/CompatRpcControllerFactory
> It is now necessary to copy 
> lib/phoenix-hbase-compat-1.5.0-4.16.0-SNAPSHOT.jar into HBase's lib directory 
> as well.
> The jar in the Phoenix directory is called: 
> phoenix-server-4.16.0-SNAPSHOT-hbase-1.5.jar, so I do not see why it could 
> not include the compatibility classes.
> Alternatively we can rename that jar to just 
> phoenix-server-4.16.0-SNAPSHOT.jar and place the compatbility jar in Phoenix' 
> top level directory and document the change.
> (Of course a release would not have SNAPSHOT in the name...)
> Marking as blocker for 4.16.0, because as is, it will bring HBase down hard 
> upon upgrade if this is not kept in mind.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to