abhishek-chouhan commented on a change in pull request #797:
URL: https://github.com/apache/phoenix/pull/797#discussion_r435701953
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1081,7 +1083,11 @@ private RegionScanner rebuildIndices(final RegionScanner
innerScanner, final Reg
rawScan.setRaw(true);
rawScan.setMaxVersions();
rawScan.getFamilyMap().clear();
- rawScan.setFilter(null);
+ if (scan.getFilter() instanceof FirstKeyOnlyFilter) {
Review comment:
Allversions filter does not only give the first key value, its purpose
is to make sure all versions of a column are returned(when matched by
underlying supplied filter), instead of just one. Usually the filters used in
normal queries(which also end up being used for rebuild since we use select
count(*)) returns only 1 version of a column, in rebuild we want to return all
versions hence this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
