abhishek-chouhan commented on a change in pull request #797:
URL: https://github.com/apache/phoenix/pull/797#discussion_r435702291
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1081,7 +1083,11 @@ private RegionScanner rebuildIndices(final RegionScanner
innerScanner, final Reg
rawScan.setRaw(true);
rawScan.setMaxVersions();
rawScan.getFamilyMap().clear();
- rawScan.setFilter(null);
+ if (scan.getFilter() instanceof FirstKeyOnlyFilter) {
+ rawScan.setFilter(null);
+ } else if (scan.getFilter() != null) {
+ rawScan.setFilter(new
AllVersionsIndexRebuildFilter(scan.getFilter()));
+ }
Review comment:
AFAIK we get raw scan here in case of old design and partial rebuild
(Correct me if i'm wrong here @kadirozde ). I didn't want to mess with the old
design and hence only made the changes for new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
