gokceni commented on a change in pull request #801:
URL: https://github.com/apache/phoenix/pull/801#discussion_r439562590
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -98,6 +103,9 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(IndexRebuildRegionScanner.class);
+ public static final String
PHOENIX_LOG_BEYOND_MAX_LOOKBACK_INVALID_ROWS_CONF_KEY =
+ "phoenix.log.beyond.max.lookback.age.invalid.rows";
+ public static final boolean
DEFAULT_PHOENIX_LOG_BEYOND_MAX_LOOKBACK_INVALID_ROWS = true;
Review comment:
Should this be false? I feel like "beyond max lookback" is kind of
analogy to debug log. Why don't we make it false?
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationOutputRepositoryIT.java
##########
@@ -53,6 +54,7 @@
import java.util.Map;
import static org.apache.phoenix.coprocessor.MetaDataProtocol.DEFAULT_LOG_TTL;
+import static
org.apache.phoenix.mapreduce.index.IndexVerificationOutputRepository.IndexVerificationErrorType.*;
Review comment:
Let's remove the *
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
