swaroopak commented on a change in pull request #801:
URL: https://github.com/apache/phoenix/pull/801#discussion_r440506967
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -152,6 +158,9 @@ public IndexRebuildRegionScanner(final RegionScanner
innerScanner, final Region
verifyType = IndexTool.IndexVerifyType.fromValue(valueBytes);
if (verifyType != IndexTool.IndexVerifyType.NONE) {
verify = true;
+ boolean shouldLogBeyondMaxLookbackInvalidRows =
+
config.getBoolean(PHOENIX_LOG_BEYOND_MAX_LOOKBACK_ERROR_ROWS_CONF_KEY,
Review comment:
It is important that we have this property overridable for each
IndexTool run. You could modify the existing/the one added in this PR run of
IndexTool to make sure the property changes from the client-side are reflecting
properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
