[
https://issues.apache.org/jira/browse/PHOENIX-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146619#comment-17146619
]
Hadoop QA commented on PHOENIX-5951:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006544/PHOENIX-5951-4.x.v3.patch
against 4.x branch at commit cea5200e94187f8c8e49ef9d17af07c088c6000e.
ATTACHMENT ID: 13006544
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ serverProps.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Long.toString(MAX_LOOKBACK_AGE));
+
System.getProperty(IndexRebuildRegionScanner.PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS);
+
System.setProperty(IndexRebuildRegionScanner.PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS,
"true");
+ deleteAllRows(conn,
TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME));
+ TestUtil.dumpTable(conn,
TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME));
+
counters.findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue());
+
System.setProperty(IndexRebuildRegionScanner.PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS,
oldProperty);
+ IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.NONE;
+ IndexVerificationErrorType errorType)
throws SQLException, IOException {
+
verificationOutputRepository.setShouldLogBeyondMaxLookback(shouldLogBeyondMaxLookbackInvalidRows);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3995//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3995//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3995//console
This message is automatically generated.
> IndexTool output logging for past-max-lookback rows should be configurable
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5951
> URL: https://issues.apache.org/jira/browse/PHOENIX-5951
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5951-4.x.v1.patch, PHOENIX-5951-4.x.v2.patch,
> PHOENIX-5951-4.x.v3.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> On a global mutable table with lots of writes, it can be possible for there
> to be many rows flagged by index verification as invalid that are older than
> the max lookback age. These are likely due to race conditions between
> compaction in the base table and index table, but they can possibly show real
> issues.
> Since heavy output logging to PHOENIX_INDEX_TOOL can cause hotspotting, some
> operators may want to turn it off for this class of failures, while still
> wanting output logging for other kinds of invalid rows.
> As part of this change, we should start including in the output row a column
> with a code identifying the type of error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
