[ https://issues.apache.org/jira/browse/PHOENIX-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147607#comment-17147607 ]
Hadoop QA commented on PHOENIX-5951: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/13006637/PHOENIX-5951-4.x.v5.patch against 4.x branch at commit e6fc80cf706518214c36a92189ab1c5dbb24a9ba. ATTACHMENT ID: 13006637 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + serverProps.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY, Long.toString(MAX_LOOKBACK_AGE)); + deleteAllRows(conn, TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME)); + set(IndexRebuildRegionScanner.PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS, "true"); + TestUtil.dumpTable(conn, TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME)); + counters.findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue()); + getUtility().getHBaseAdmin().disableTable(TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME)); + getUtility().getHBaseAdmin().truncateTable(TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME), true); + IndexTool.IndexDisableLoggingType disableLoggingVerifyType = IndexTool.IndexDisableLoggingType.NONE; + IndexVerificationErrorType errorType) throws SQLException, IOException { + scan.getAttribute(BaseScannerRegionObserver.INDEX_REBUILD_DISABLE_LOGGING_BEYOND_MAXLOOKBACK_AGE); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3998//testReport/ Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3998//artifact/phoenix-core/target/site/jacoco/index.html Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3998//console This message is automatically generated. > IndexTool output logging for past-max-lookback rows should be configurable > -------------------------------------------------------------------------- > > Key: PHOENIX-5951 > URL: https://issues.apache.org/jira/browse/PHOENIX-5951 > Project: Phoenix > Issue Type: Improvement > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > Priority: Major > Attachments: PHOENIX-5951-4.x.v1.patch, PHOENIX-5951-4.x.v2.patch, > PHOENIX-5951-4.x.v3.patch, PHOENIX-5951-4.x.v4.patch, > PHOENIX-5951-4.x.v5.patch > > Time Spent: 4h > Remaining Estimate: 0h > > On a global mutable table with lots of writes, it can be possible for there > to be many rows flagged by index verification as invalid that are older than > the max lookback age. These are likely due to race conditions between > compaction in the base table and index table, but they can possibly show real > issues. > Since heavy output logging to PHOENIX_INDEX_TOOL can cause hotspotting, some > operators may want to turn it off for this class of failures, while still > wanting output logging for other kinds of invalid rows. > As part of this change, we should start including in the output row a column > with a code identifying the type of error. -- This message was sent by Atlassian Jira (v8.3.4#803005)