kadirozde commented on pull request #860: URL: https://github.com/apache/phoenix/pull/860#issuecomment-677915427
I do not see any relation between Single Responsibility Principle and what we are talking about. What we are talking about how IndexRebuildRegionScanner can use the functionality provided by UARO. There is no responsibility sharing in terms of detecting region closing and splits and actions to be taken after. In this PR, IndexRebuildRegionScanner scanner knows about UARO and uses the functionality UARO implements. You suggest that IndexRebuildRegionScanner should not know about UARO, should not know about region close and splits, and should be instructed to stop its operation. However, it should somehow know magically what to do when it stops its operation. Sorry, that does not make sense to me. Making this implicit for the sake of decoupling and abstracting does not work in this case and there is no problem with the current client /user (IndexRebuildRegionScanner) and server/provider (UARO) model used here as far as I see. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
