gjacoby126 commented on pull request #860:
URL: https://github.com/apache/phoenix/pull/860#issuecomment-677969630
Simplifying the testing is a bonus, not the reason. Code classes should be
highly cohesive and loosely coupled. Standard OO principles. :-) This change
makes the rebuild scanner less cohesive and more tightly coupled to UARO.
I'm not really sure why (isClosed()) { throw new IOException("Some
informative message") }, where isClosed() checks some AtomicBoolean local to
the scanner, would be harder to read than a call to
UARO.checkRegionClosingOrSplitting. It does add some bookkeeping to UARO, but
it already has a spot for that in the waitForScanners method.
That said, I will not veto this patch as it is if you approve it, @kadirozde
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
