[
https://issues.apache.org/jira/browse/PHOENIX-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183637#comment-17183637
]
Josh Elser commented on PHOENIX-5881:
-------------------------------------
{code:java}
+ if (!isMaxLookbackSupported) {
+ return;
+ } {code}
nit: JUnit has the {{Assume}} class which you could use to skip this test
instead of letting it "pass".
{code:java}
+ CANNOT_QUERY_TABLE_WITH_SCN_OLDER_THAN_MAX_LOOKBACK_AGE(538, "42915",
+ "Cannot use SCN to look further back in the past beyond the configured
max lookback age"),{code}
nit: Looks like indentation is off here.
{code:java}
+ private boolean isTransactionalTimestamp(long ts) {
+ //have to use the HBase edge manager because the Phoenix one is in
phoenix-core
+ return ts > (long) (EnvironmentEdgeManager.currentTime() * 1.1);
+ }
{code}
This looks pretty quirky. What's going on here?
Let me see if I can rekick QA.
> Port MaxLookbackAge logic to 5.x
> --------------------------------
>
> Key: PHOENIX-5881
> URL: https://issues.apache.org/jira/browse/PHOENIX-5881
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5881.v1.patch, PHOENIX-5881.v2.patch,
> PHOENIX-5881.v3.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> PHOENIX-5645 wasn't included in the master (5.x) branch because an HBase 2.x
> change prevented the logic from being useful in the case of deletes, since
> HBase 2.x no longer allows us to show deleted cells on an SCN query before
> the point of deletion. Unfortunately, PHOENIX-5645 wound up requiring a lot
> of follow-up work in the IndexTool and IndexScrutinyTool to deal with its
> implications, and because of that, the 4.x and 5.x codebases around indexes
> have diverged a good bit.
> This work item is to get them back in sync, even though the behavior in the
> face of deletes will be somewhat different, and so most likely some tests
> will have to be changed or Ignored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
