[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185864#comment-17185864
]
Istvan Toth commented on PHOENIX-6107:
--------------------------------------
I've uploaded the @BeforeParam patch.
The basic idea is the same as [~ankit]'s InListIT patch, it's just a bit nicer
implementation due to using the new Junit 4.13 feature.
Tests run in 20-80 seconds each on my machine, PointInTimeQueryIT is still
slow, because I had to keep the old effective behaviour there. (also moved some
tests there, so that they do not interfere with the rest of the tests, and
benefit from the HBase 2.3 feature)
> Discuss speed up of BaseQueryIT
> -------------------------------
>
> Key: PHOENIX-6107
> URL: https://issues.apache.org/jira/browse/PHOENIX-6107
> Project: Phoenix
> Issue Type: Wish
> Reporter: Lars Hofhansl
> Priority: Major
> Attachments: 6107-master.txt, 6107-proposal.txt,
> PHOENIX-6107-stoty.master.v1.patch
>
>
> All 14 tests derived from BaseQueryIT are some of the slowest we have.
> I noticed that all these tests run 7 times and each time create a table and 6
> indexes.
> So just in terms of setup there are 14*7 = 98 tables created and 14*7*6 = 588
> indexes created.
> It's not clear to me that that the runtime is justified, especially since we
> have so many other index ITs.
> I think we can reduce this to run with one global index and one local index,
> for a repeat of only 3 times, instead of 7. That would benefit all derived
> test and shave of probably around 50% of the overall Phoenix test runtime.
> I.e. 14*3 = 42 tables, and 14*3*2 = 84 indexes.
> Could even go as far and test with no indexes here.
> Yes, it would potentially reduce coverage. Hence a discussion.
> Thoughts?
> (Marked as "Wish" so that we can discuss)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
