[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185933#comment-17185933
]
Hadoop QA commented on PHOENIX-6107:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13010620/PHOENIX-6107-stoty.master.v1.patch
against master branch at commit .
ATTACHMENT ID: 13010620
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public AggregateQueryIT(String indexDDL, boolean columnEncoded,
boolean keepDeletedCells) throws Exception {
+ public static final void initTables(String idxDdl, boolean columnEncoded,
boolean keepDeletedCells) throws Exception {
+ public BaseQueryIT(String idxDdl, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
+ testCases.add(new Object[] { indexDDL, columnEncoded,
!HbaseCompatCapabilities.isLookbackBeyondDeletesSupported()});
+ public CaseStatementIT(String indexDDL, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
+ public CastAndCoerceIT(String indexDDL, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
+ public GroupByIT(String indexDDL, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
+ public InQueryIT(String indexDDL, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
+ public IntArithmeticIT(String indexDDL, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
+ protected NotQueryIT(String indexDDL, boolean columnEncoded, boolean
keepDeletedCells) throws Exception {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PermissionNSDisabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
Test results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59//testReport/
Code Coverage results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/59//console
This message is automatically generated.
> Discuss speed up of BaseQueryIT
> -------------------------------
>
> Key: PHOENIX-6107
> URL: https://issues.apache.org/jira/browse/PHOENIX-6107
> Project: Phoenix
> Issue Type: Wish
> Reporter: Lars Hofhansl
> Priority: Major
> Attachments: 6107-master.txt, 6107-proposal.txt,
> PHOENIX-6107-stoty.master.v1.patch
>
>
> All 14 tests derived from BaseQueryIT are some of the slowest we have.
> I noticed that all these tests run 7 times and each time create a table and 6
> indexes.
> So just in terms of setup there are 14*7 = 98 tables created and 14*7*6 = 588
> indexes created.
> It's not clear to me that that the runtime is justified, especially since we
> have so many other index ITs.
> I think we can reduce this to run with one global index and one local index,
> for a repeat of only 3 times, instead of 7. That would benefit all derived
> test and shave of probably around 50% of the overall Phoenix test runtime.
> I.e. 14*3 = 42 tables, and 14*3*2 = 84 indexes.
> Could even go as far and test with no indexes here.
> Yes, it would potentially reduce coverage. Hence a discussion.
> Thoughts?
> (Marked as "Wish" so that we can discuss)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
