[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193910#comment-17193910
]
Geoffrey Jacoby commented on PHOENIX-6067:
------------------------------------------
[~elserj] - I think you just missed my push deactivating
IndexToolForNonTxGlobalIndexIT. testEnableOutputLoggingForMaxLookback for 2.1
and 2.2.
I've pushed up additional changes deactivating under 2.1 a lot of tests using
raw filters in some way (either view index rebuilds or incremental index
rebuilds), including the IndexUpgradeToolTest you found.
Fixed the whitespace issue in TestUtil.dumpTable.
Refactored htableFactory and indexHTable to be disposed of in the superclass
close(); thanks for the suggestion.
The familyMap potential NPE issues you raise look like valid concerns, but I'd
rather tackle those as a separate JIRA because the same logic is in 4.x and
would need to be fixed both places.
As for a new VerifyType coming from a newer client, I believe best practice is
to upgrade Phoenix server first and clients second (this is enforced in the
code for minor and major version upgrades), and I don't see a new VerifyType
coming in on a patch release.
> (5.x) Global Secondary Index Parity with 4.x
> --------------------------------------------
>
> Key: PHOENIX-6067
> URL: https://issues.apache.org/jira/browse/PHOENIX-6067
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Geoffrey Jacoby
> Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6067.v1.patch, PHOENIX-6067.v2.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A large number of indexing JIRAs were done for Phoenix 4.16 but were
> originally unable to be ported to 5.x because of the lack of HBase 2.x
> support for PHOENIX-5645, max lookback age. This was eventually fixed in
> HBASE-24321 and PHOENIX-5881. Because some JIRAs later than the missing ones
> _were_ ported to 5.x, applying them all one-by-one and testing each
> intermediate version would be impractical.
> This JIRA will import the 4.16 global index implementation into 5.1.0, then
> fix HBase API usage to conform to HBase 2.x standards and Phoenix's HBase 2.x
> compatibility shim between minor versions. (For example, max lookback age
> features aren't supported in 2.1 and 2.2 because they lack HBASE-24321, and
> incremental index validation will be deactivated when running against HBase
> 2.1, because of the lack of HBASE-22710 to use raw Filters.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
