[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193948#comment-17193948
]
Hadoop QA commented on PHOENIX-6067:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13011366/PHOENIX-6067.v3.patch
against master branch at commit .
ATTACHMENT ID: 13011366
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 16 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
props.put(QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB,
Long.toString(0));
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_MISSING_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_INVALID_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_OLD_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_UNKNOWN_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/84//testReport/
Code Coverage results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/84//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/84//console
This message is automatically generated.
> (5.x) Global Secondary Index Parity with 4.x
> --------------------------------------------
>
> Key: PHOENIX-6067
> URL: https://issues.apache.org/jira/browse/PHOENIX-6067
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Geoffrey Jacoby
> Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6067.v1.patch, PHOENIX-6067.v2.patch,
> PHOENIX-6067.v3.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A large number of indexing JIRAs were done for Phoenix 4.16 but were
> originally unable to be ported to 5.x because of the lack of HBase 2.x
> support for PHOENIX-5645, max lookback age. This was eventually fixed in
> HBASE-24321 and PHOENIX-5881. Because some JIRAs later than the missing ones
> _were_ ported to 5.x, applying them all one-by-one and testing each
> intermediate version would be impractical.
> This JIRA will import the 4.16 global index implementation into 5.1.0, then
> fix HBase API usage to conform to HBase 2.x standards and Phoenix's HBase 2.x
> compatibility shim between minor versions. (For example, max lookback age
> features aren't supported in 2.1 and 2.2 because they lack HBASE-24321, and
> incremental index validation will be deactivated when running against HBase
> 2.1, because of the lack of HBASE-22710 to use raw Filters.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
