[
https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204843#comment-17204843
]
ASF GitHub Bot commented on PHOENIX-6151:
-----------------------------------------
stoty commented on pull request #890:
URL: https://github.com/apache/phoenix/pull/890#issuecomment-701489628
Unfortunately we don't have tests to thoroughly check the shaded client.
I have run a proprietary test suite on this that runs tests via sqlline, and
it didn't throw up any errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Switch phoenix-client to shade-by-default mode
> ----------------------------------------------
>
> Key: PHOENIX-6151
> URL: https://issues.apache.org/jira/browse/PHOENIX-6151
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Phoenix-client contains Phoenix, plus most of a Hadoop+Hbase stack.
> We keep running into difficulties, where phoenix-client conflicts with user
> code, or in the case of connectors with different components.
> Instead of shading packages explicitly, try the approach of shading
> everything, and only keeping unshaded the libraries that cannot be shaded.
> This is the approach taken by Hadoop.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
