[
https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210315#comment-17210315
]
ASF GitHub Bot commented on PHOENIX-6151:
-----------------------------------------
stoty commented on pull request #890:
URL: https://github.com/apache/phoenix/pull/890#issuecomment-705685752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 58s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 51s | master passed |
| +1 :green_heart: | compile | 1m 18s | master passed |
| +1 :green_heart: | javadoc | 1m 19s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 32m 21s | the patch passed |
| +1 :green_heart: | compile | 1m 18s | the patch passed |
| +1 :green_heart: | javac | 1m 18s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 14s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 163m 34s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate
ASF License warnings. |
| | | 217m 59s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.ConcurrentMutationsExtendedIT |
| | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/890 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 8f22da7b028c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 92e5908 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/artifact/yetus-general-check/output/whitespace-eol.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/testReport/
|
| Max. process+thread count | 6865 (vs. ulimit of 30000) |
| modules | C: phoenix-client . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Switch phoenix-client to shade-by-default mode
> ----------------------------------------------
>
> Key: PHOENIX-6151
> URL: https://issues.apache.org/jira/browse/PHOENIX-6151
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Phoenix-client contains Phoenix, plus most of a Hadoop+Hbase stack.
> We keep running into difficulties, where phoenix-client conflicts with user
> code, or in the case of connectors with different components.
> Instead of shading packages explicitly, try the approach of shading
> everything, and only keeping unshaded the libraries that cannot be shaded.
> This is the approach taken by Hadoop.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
