[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209265#comment-17209265
]
Hadoop QA commented on PHOENIX-5435:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 5m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} 4.x Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
14s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
7s{color} | {color:green} 4.x passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
24s{color} | {color:blue} phoenix-hbase-compat-1.5.0 in 4.x has 3 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
21s{color} | {color:blue} phoenix-hbase-compat-1.4.0 in 4.x has 3 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
20s{color} | {color:blue} phoenix-hbase-compat-1.3.0 in 4.x has 3 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
42s{color} | {color:blue} phoenix-core in 4.x has 957 extant spotbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
42s{color} | {color:blue} root in 4.x has 1011 extant spotbugs warnings.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 3m
22s{color} | {color:red} root: The patch generated 272 new + 6145 unchanged -
41 fixed = 6417 total (was 6186) {color} |
| {color:green}+1{color} | {color:green} prototool {color} | {color:green} 0m
1s{color} | {color:green} There were no new prototool issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
40s{color} | {color:red} phoenix-core generated 1 new + 99 unchanged - 1 fixed
= 100 total (was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
5s{color} | {color:red} root generated 1 new + 131 unchanged - 1 fixed = 132
total (was 132) {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m
6s{color} | {color:red} phoenix-core generated 4 new + 956 unchanged - 1 fixed
= 960 total (was 957) {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 4m
6s{color} | {color:red} root generated 4 new + 1010 unchanged - 1 fixed = 1014
total (was 1011) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m 1s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL
isn't final but should be At IndexRegionObserver.java:be At
IndexRegionObserver.java:[line 125] |
| |
org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL
isn't final but should be At IndexRegionObserver.java:be At
IndexRegionObserver.java:[line 124] |
| | Load of known null value in
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
List, long) At IndexRegionObserver.java:in
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
List, long) At IndexRegionObserver.java:[line 719] |
| | Switch statement found in
org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue()
where default case is missing At FilteredKeyValueScanner.java:where default
case is missing At FilteredKeyValueScanner.java:[lines 84-101] |
| FindBugs | module:root |
| |
org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL
isn't final but should be At IndexRegionObserver.java:be At
IndexRegionObserver.java:[line 125] |
| |
org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL
isn't final but should be At IndexRegionObserver.java:be At
IndexRegionObserver.java:[line 124] |
| | Load of known null value in
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
List, long) At IndexRegionObserver.java:in
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
List, long) At IndexRegionObserver.java:[line 719] |
| | Switch statement found in
org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue()
where default case is missing At FilteredKeyValueScanner.java:where default
case is missing At FilteredKeyValueScanner.java:[lines 84-101] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-5435 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13013168/PHOENIX-5435-4.x.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool xml |
| uname | Linux 1ddcbe0f0e5e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 3008ca9 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/diff-checkstyle-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/whitespace-eol.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/diff-javadoc-javadoc-phoenix-core.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/diff-javadoc-javadoc-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/new-spotbugs-phoenix-core.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/new-spotbugs-root.html
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/testReport/ |
| Max. process+thread count | 6082 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0
phoenix-hbase-compat-1.3.0 phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/65/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Annotate HBase WALs with Phoenix Metadata
> -----------------------------------------
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple <tenant_id, table-or-view-name, timestamp>, or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
