[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229614#comment-17229614
]
ASF GitHub Bot commented on PHOENIX-5435:
-----------------------------------------
gjacoby126 commented on pull request #913:
URL: https://github.com/apache/phoenix/pull/913#issuecomment-725058655
1. This feature requires a 4.16 client and a 4.16 server. The server code is
intended to gracefully no-op and not annotate if the client hasn't provided
anything.
2. The question would be how to store the list of tables to annotate, since
so much of the logic is client-side where we don't have the server-side
hbase-site.xml. It could be Yet Another PTable Attribute, but I'm unsure if
it's worth the complexity -- wdyt? The conceptually cleanest way would be to
annotate replicated tables and not annotate unreplicated ones, but replication
scope is on the TableDescriptor, which we don't usually have access to
client-side.
A critique I received offline to this PR from @priyankporwal suggested that
annotating indexes might not be worth the storage cost, so we could also
consider exempting indexes in the next draft (which is waiting on PHOENIX-6186
to populate the DDL timestamps)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Annotate HBase WALs with Phoenix Metadata
> -----------------------------------------
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple <tenant_id, table-or-view-name, timestamp>, or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
