stoty commented on pull request #913:
URL: https://github.com/apache/phoenix/pull/913#issuecomment-704670166


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   6m 59s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
2 new or modified test files.  |
   ||| _ 4.x Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 43s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   9m 16s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m 53s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   3m 23s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   3m  7s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   0m 35s |  phoenix-hbase-compat-1.5.0 in 4.x has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 30s |  phoenix-hbase-compat-1.4.0 in 4.x has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 28s |  phoenix-hbase-compat-1.3.0 in 4.x has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   5m 46s |  root in 4.x has 1011 extant spotbugs 
warnings.  |
   | +0 :ok: |  spotbugs  |   3m 29s |  phoenix-core in 4.x has 957 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 48s |  the patch passed  |
   | +1 :green_heart: |  cc  |   1m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 48s |  the patch passed  |
   | -1 :x: |  checkstyle  |   3m 35s |  root: The patch generated 272 new + 
6145 unchanged - 41 fixed = 6417 total (was 6186)  |
   | +1 :green_heart: |  prototool  |   0m  2s |  There were no new prototool 
issues.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 1 line(s) that end in 
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   3m  5s |  the patch passed  |
   | -1 :x: |  spotbugs  |   4m  0s |  phoenix-core generated 4 new + 956 
unchanged - 1 fixed = 960 total (was 957)  |
   | -1 :x: |  spotbugs  |   5m 29s |  root generated 4 new + 1010 unchanged - 
1 fixed = 1014 total (was 1011)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 143m 30s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   2m 56s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 214m 11s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 125] |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 124] |
   |  |  Load of known null value in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:[line 719] |
   |  |  Switch statement found in 
org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue()
 where default case is missing  At FilteredKeyValueScanner.java:where default 
case is missing  At FilteredKeyValueScanner.java:[lines 84-101] |
   | FindBugs | module:root |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 125] |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 124] |
   |  |  Load of known null value in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:[line 719] |
   |  |  Switch statement found in 
org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue()
 where default case is missing  At FilteredKeyValueScanner.java:where default 
case is missing  At FilteredKeyValueScanner.java:[lines 84-101] |
   | Failed junit tests | phoenix.end2end.ViewMetadataIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/913 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile cc prototool xml |
   | uname | Linux 989c2b3fb99f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 3008ca9 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/whitespace-eol.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/new-spotbugs-root.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/testReport/
 |
   | Max. process+thread count | 5708 (vs. ulimit of 30000) |
   | modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 
phoenix-hbase-compat-1.3.0 phoenix-core . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to