stoty commented on pull request #913:
URL: https://github.com/apache/phoenix/pull/913#issuecomment-734013444


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   4m 11s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
3 new or modified test files.  |
   ||| _ 4.x Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  10m 44s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m 25s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |  10m 32s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   2m 22s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   0m 27s |  phoenix-hbase-compat-1.5.0 in 4.x has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 22s |  phoenix-hbase-compat-1.4.0 in 4.x has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 24s |  phoenix-hbase-compat-1.3.0 in 4.x has 3 
extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   3m 59s |  root in 4.x has 1004 extant spotbugs 
warnings.  |
   | +0 :ok: |  spotbugs  |   2m 38s |  phoenix-core in 4.x has 950 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 59s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  cc  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 28s |  the patch passed  |
   | -1 :x: |  checkstyle  |  10m 46s |  root: The patch generated 541 new + 
23086 unchanged - 193 fixed = 23627 total (was 23279)  |
   | +1 :green_heart: |  prototool  |   0m  1s |  There were no new prototool 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   2m 26s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m 11s |  phoenix-core generated 5 new + 950 
unchanged - 0 fixed = 955 total (was 950)  |
   | -1 :x: |  spotbugs  |   4m 12s |  root generated 5 new + 1004 unchanged - 
0 fixed = 1009 total (was 1004)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 143m 37s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 45s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 214m 46s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 126] |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 125] |
   |  |  Load of known null value in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:[line 800] |
   |  |  Switch statement found in 
org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue()
 where default case is missing  At FilteredKeyValueScanner.java:where default 
case is missing  At FilteredKeyValueScanner.java:[lines 84-101] |
   |  |  
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES 
is a mutable array  At MetaDataEndpointImpl.java: At 
MetaDataEndpointImpl.java:[line 336] |
   | FindBugs | module:root |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 126] |
   |  |  
org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL
 isn't final but should be  At IndexRegionObserver.java:be  At 
IndexRegionObserver.java:[line 125] |
   |  |  Load of known null value in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:in 
org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext,
 List, long)  At IndexRegionObserver.java:[line 800] |
   |  |  Switch statement found in 
org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue()
 where default case is missing  At FilteredKeyValueScanner.java:where default 
case is missing  At FilteredKeyValueScanner.java:[lines 84-101] |
   |  |  
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES 
is a mutable array  At MetaDataEndpointImpl.java: At 
MetaDataEndpointImpl.java:[line 336] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/913 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile cc prototool xml |
   | uname | Linux c23295b9be68 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 7ac4dff |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/new-spotbugs-root.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/testReport/
 |
   | Max. process+thread count | 5945 (vs. ulimit of 30000) |
   | modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 
phoenix-hbase-compat-1.3.0 phoenix-core . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to