[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235589#comment-17235589
]
ASF GitHub Bot commented on PHOENIX-6186:
-----------------------------------------
gjacoby126 commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r527049260
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java
##########
@@ -91,122 +100,6 @@
@Category(NeedsOwnMiniClusterTest.class)
public class UpgradeIT extends ParallelStatsDisabledIT {
- @Test
- public void testMapTableToNamespaceDuringUpgrade()
- throws SQLException, IOException, IllegalArgumentException,
InterruptedException {
- String[] strings = new String[] { "a", "b", "c", "d" };
-
- try (Connection conn = DriverManager.getConnection(getUrl())) {
- String schemaName = "TEST";
- String phoenixFullTableName = schemaName + "." +
generateUniqueName();
- String indexName = "IDX_" + generateUniqueName();
- String localIndexName = "LIDX_" + generateUniqueName();
-
- String viewName = "VIEW_" + generateUniqueName();
- String viewIndexName = "VIDX_" + generateUniqueName();
-
- String[] tableNames = new String[] { phoenixFullTableName,
schemaName + "." + indexName,
- schemaName + "." + localIndexName, "diff." + viewName,
"test." + viewName, viewName};
- String[] viewIndexes = new String[] { "diff." + viewIndexName,
"test." + viewIndexName };
- conn.createStatement().execute("CREATE TABLE " +
phoenixFullTableName
- + "(k VARCHAR PRIMARY KEY, v INTEGER, f INTEGER, g INTEGER
NULL, h INTEGER NULL)");
- PreparedStatement upsertStmt = conn
- .prepareStatement("UPSERT INTO " + phoenixFullTableName +
" VALUES(?, ?, 0, 0, 0)");
- int i = 1;
- for (String str : strings) {
- upsertStmt.setString(1, str);
- upsertStmt.setInt(2, i++);
- upsertStmt.execute();
- }
- conn.commit();
- // creating local index
- conn.createStatement()
- .execute("create local index " + localIndexName + " on " +
phoenixFullTableName + "(K)");
- // creating global index
- conn.createStatement().execute("create index " + indexName + " on
" + phoenixFullTableName + "(k)");
- // creating view in schema 'diff'
- conn.createStatement().execute("CREATE VIEW diff." + viewName + "
(col VARCHAR) AS SELECT * FROM " + phoenixFullTableName);
- // creating view in schema 'test'
- conn.createStatement().execute("CREATE VIEW test." + viewName + "
(col VARCHAR) AS SELECT * FROM " + phoenixFullTableName);
- conn.createStatement().execute("CREATE VIEW " + viewName + "(col
VARCHAR) AS SELECT * FROM " + phoenixFullTableName);
- // Creating index on views
- conn.createStatement().execute("create index " + viewIndexName + "
on diff." + viewName + "(col)");
- conn.createStatement().execute("create index " + viewIndexName + "
on test." + viewName + "(col)");
-
- // validate data
- for (String tableName : tableNames) {
- ResultSet rs = conn.createStatement().executeQuery("select *
from " + tableName);
- for (String str : strings) {
- assertTrue(rs.next());
- assertEquals(str, rs.getString(1));
- }
- }
-
- // validate view Index data
- for (String viewIndex : viewIndexes) {
- ResultSet rs = conn.createStatement().executeQuery("select *
from " + viewIndex);
- for (String str : strings) {
- assertTrue(rs.next());
- assertEquals(str, rs.getString(2));
- }
- }
-
- HBaseAdmin admin =
conn.unwrap(PhoenixConnection.class).getQueryServices().getAdmin();
- assertTrue(admin.tableExists(phoenixFullTableName));
- assertTrue(admin.tableExists(schemaName +
QueryConstants.NAME_SEPARATOR + indexName));
-
assertTrue(admin.tableExists(MetaDataUtil.getViewIndexPhysicalName(Bytes.toBytes(phoenixFullTableName))));
- Properties props = new Properties();
- props.setProperty(QueryServices.IS_NAMESPACE_MAPPING_ENABLED,
Boolean.toString(true));
-
props.setProperty(QueryServices.IS_SYSTEM_TABLE_MAPPED_TO_NAMESPACE,
Boolean.toString(false));
- admin.close();
- PhoenixConnection phxConn = DriverManager.getConnection(getUrl(),
props).unwrap(PhoenixConnection.class);
- UpgradeUtil.upgradeTable(phxConn, phoenixFullTableName);
- phxConn.close();
- props = new Properties();
- phxConn = DriverManager.getConnection(getUrl(),
props).unwrap(PhoenixConnection.class);
- // purge MetaDataCache except for system tables
- phxConn.getMetaDataCache().pruneTables(new PMetaData.Pruner() {
- @Override public boolean prune(PTable table) {
- return table.getType() != PTableType.SYSTEM;
- }
-
- @Override public boolean prune(PFunction function) {
- return false;
- }
- });
- admin = phxConn.getQueryServices().getAdmin();
- String hbaseTableName =
SchemaUtil.getPhysicalTableName(Bytes.toBytes(phoenixFullTableName), true)
- .getNameAsString();
- assertTrue(admin.tableExists(hbaseTableName));
- assertTrue(admin.tableExists(Bytes.toBytes(hbaseTableName)));
- assertTrue(admin.tableExists(schemaName +
QueryConstants.NAMESPACE_SEPARATOR + indexName));
-
assertTrue(admin.tableExists(MetaDataUtil.getViewIndexPhysicalName(Bytes.toBytes(hbaseTableName))));
- i = 0;
- // validate data
- for (String tableName : tableNames) {
- ResultSet rs = phxConn.createStatement().executeQuery("select
* from " + tableName);
- for (String str : strings) {
- assertTrue(rs.next());
- assertEquals(str, rs.getString(1));
- }
- }
- // validate view Index data
- for (String viewIndex : viewIndexes) {
- ResultSet rs = conn.createStatement().executeQuery("select *
from " + viewIndex);
- for (String str : strings) {
- assertTrue(rs.next());
- assertEquals(str, rs.getString(2));
- }
- }
- PName tenantId = phxConn.getTenantId();
- PName physicalName = PNameFactory.newName(hbaseTableName);
- String newSchemaName =
MetaDataUtil.getViewIndexSequenceSchemaName(physicalName, true);
- String newSequenceName =
MetaDataUtil.getViewIndexSequenceName(physicalName, tenantId, true);
- verifySequenceValue(null, newSequenceName, newSchemaName,
Short.MIN_VALUE + 3);
- admin.close();
- }
- }
-
@Test
public void testMapMultiTenantTableToNamespaceDuringUpgrade() throws
SQLException, SnapshotCreationException,
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Store table metadata last modified timestamp in PTable / System.Catalog
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6186
> URL: https://issues.apache.org/jira/browse/PHOENIX-6186
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6186-4.x.patch
>
>
> There are many reasons why it's useful to know when a particular table's
> metadata was last modified. It's helpful when solving cache coherency
> problems, and also in order to interact with external schema registries which
> may have multiple versions of a particular schema and require a timestamp to
> resolve ambiguities.
> This JIRA will add a last modified timestamp field to System.Catalog, to be
> updated both when creating a table/view and also when adding or removing a
> column. Changing purely internal Phoenix properties will not update the
> timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
