[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236494#comment-17236494
]
ASF GitHub Bot commented on PHOENIX-6186:
-----------------------------------------
stoty commented on pull request #977:
URL: https://github.com/apache/phoenix/pull/977#issuecomment-731446812
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 42s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 3m 38s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 42s | master passed |
| +1 :green_heart: | compile | 1m 26s | master passed |
| +1 :green_heart: | checkstyle | 7m 30s | master passed |
| +1 :green_heart: | javadoc | 1m 58s | master passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in master has 965 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 11s | root in master has 1014 extant spotbugs
warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 9m 26s | the patch passed |
| +1 :green_heart: | compile | 1m 25s | the patch passed |
| +1 :green_heart: | cc | 1m 25s | the patch passed |
| +1 :green_heart: | javac | 1m 25s | the patch passed |
| -1 :x: | checkstyle | 7m 26s | root: The patch generated 371 new +
25007 unchanged - 255 fixed = 25378 total (was 25262) |
| +1 :green_heart: | prototool | 0m 2s | There were no new prototool
issues. |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| -1 :x: | javadoc | 0m 51s | phoenix-core generated 1 new + 99
unchanged - 1 fixed = 100 total (was 100) |
| -1 :x: | javadoc | 1m 13s | root generated 1 new + 131 unchanged - 1
fixed = 132 total (was 132) |
| -1 :x: | spotbugs | 3m 40s | phoenix-core generated 2 new + 964
unchanged - 1 fixed = 966 total (was 965) |
| -1 :x: | spotbugs | 4m 47s | root generated 2 new + 1013 unchanged -
1 fixed = 1015 total (was 1014) |
||| _ Other Tests _ |
| -1 :x: | unit | 168m 43s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate
ASF License warnings. |
| | | 238m 1s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a
mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line
337] |
| | A prepared statement is generated from a nonconstant String in
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At
UpgradeUtil.java:from a nonconstant String in
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At
UpgradeUtil.java:[line 2616] |
| FindBugs | module:root |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a
mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line
337] |
| | A prepared statement is generated from a nonconstant String in
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At
UpgradeUtil.java:from a nonconstant String in
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At
UpgradeUtil.java:[line 2616] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/977 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool |
| uname | Linux 104e3966bebc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 2af2adf |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/new-spotbugs-root.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/testReport/
|
| Max. process+thread count | 6271 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Store table metadata last modified timestamp in PTable / System.Catalog
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6186
> URL: https://issues.apache.org/jira/browse/PHOENIX-6186
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6186-4.x.patch
>
>
> There are many reasons why it's useful to know when a particular table's
> metadata was last modified. It's helpful when solving cache coherency
> problems, and also in order to interact with external schema registries which
> may have multiple versions of a particular schema and require a timestamp to
> resolve ambiguities.
> This JIRA will add a last modified timestamp field to System.Catalog, to be
> updated both when creating a table/view and also when adding or removing a
> column. Changing purely internal Phoenix properties will not update the
> timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
